I've recently refactored my controller by creating a Trait and moving some methods into it:
Here is the original code in my controller (with one method):
public function edit(Product $product)
{
$categories = Category::get();
$main_image = $product->images()->where('main_image', 1)->first();
if ($main_image) {
$image = [];
$FileUploader = new \FileUploader('other_images',[
'uploadDir' => public_path('/uploads/product_images/'),
'title' => 'auto'
]);
$images = $FileUploader->upload();
foreach ($images['files'] as $img) {
ProductImage::create([
'image' => $img['name'],
'product_id' => $product->id,
'main_image' => false,
]);
}
}
$other_images = $product->images()->where('main_image', 0)->get();
if ($other_images) {
$images = [];
$image[] = [
"name" => $main_image->image,
"type" => \FileUploader::mime_content_type($main_image->image_path),
"size" => filesize('uploads/product_images/' . $main_image['image']),
"file" => $main_image->image_path,
"local" => $main_image->image_path,
'data' => [
"id" => $main_image->id,
],
];
}
return view('merchant.product.update',compact(
'product',
'categories',
'image',
'images'
));
}
After implementing the Trait:
public function edit(Product $product)
{
$categories = Category::get();
$main_image = $product->images()->where('main_image', 1)->first();
if ($main_image) {
$image = [];
$this->ShowMainImage($main_image, $image);
}
$other_images = $product->images()->where('main_image', 0)->get();
if ($other_images) {
$images = [];
$this->ShowOtherImages($other_images,$images);
}
return view('merchant.product.update',compact(
'product',
'categories',
'image',
'images'
));
}
The Trait I created:
trait ProductTrait{
public function ShowMainImage($main_image,$image)
{
$image[] = [
"name" => $main_image->image,
"type" => \FileUploader::mime_content_type($main_image->image_path),
"size" => filesize('uploads/product_images/' . $main_image['image']),
"file" => $main_image->image_path,
"local" => $main_image->image_path,
'data' => [
"id" => $main_image->id,
],
];
}
public function ShowOtherImages($other_images,$images)
{
foreach ($other_images as $image) {
$images[] = [
"name" => $image->image,
"type" => \FileUploader::mime_content_type($image->image_path),
"size" => filesize('uploads/product_images/' . $image['image']),
"file" => $image->image_path,
"local" => $image->image_path,
'data' => [
"id" => $image->id,
],
];
}
}
}
The first version works fine, but the second one is encountering issues with the arrays $image and $images
How can I pass an empty array to the Trait and receive back the populated data array?