Getting the error code from eslint while running in a pre-commit hook - what's the solution?

Question

Getting the error code from eslint while running in a pre-commit hook - what's the solution?

In the .git/hooks/pre-commit file of my project, I have the following script:

npx eslint --max-warnings 1 --exit-on-fatal-error $(git diff --name-only HEAD **/*.ts | xargs)

status=$?

if [ $status -eq 0 ]
then
  echo "Good"
  exit 2
fi

if [ $status -eq 1 ]
then
  echo "Bad"
  exit 2
fi

if [ $status -eq 2 ]
then
  echo "Worse"
  exit 2
fi

Regardless of valid ESLint errors present, the script always outputs "Good". When running ESLint directly in the CLI, it correctly identifies errors:

$ npx eslint --max-warnings 0 --exit-on-fatal-error make/link/fold/index.ts

./make/link/fold/index.ts
  325:14  error  Expected a default case  default-case

✖ 1 problem (1 error, 0 warnings)

How can I capture ESLint errors and prevent commits when errors are detected?

This configuration is new to me as I've only used ESLint in other projects. I've been trying to figure this out for some time with no success.

node.js bash git eslint pre-commit-hook

Answer 1

Answer №1

My proposed solution:

while read -r input; do
  npx eslint --max-warnings 1 --exit-on-fatal-error "$input"
  response=$?

  case $response in
    0)
      echo "Great"
      exit 0
    ;;
    1)
      echo "Not so good"
      exit 1
    ;;
    2)
      echo "Terrible"
      exit 2
    ;;
    *)
      echo "Confused"
      exit 3
    ;;
  esac
done < <(git diff --name-only HEAD **/*.ts)

The case statement allows you to compare a word with multiple patterns and perform actions based on the match. Refer to and as well as 'case word in' in man bash.

Answer 2

My proposed solution:

while read -r input; do
  npx eslint --max-warnings 1 --exit-on-fatal-error "$input"
  response=$?

  case $response in
    0)
      echo "Great"
      exit 0
    ;;
    1)
      echo "Not so good"
      exit 1
    ;;
    2)
      echo "Terrible"
      exit 2
    ;;
    *)
      echo "Confused"
      exit 3
    ;;
  esac
done < <(git diff --name-only HEAD **/*.ts)

The case statement allows you to compare a word with multiple patterns and perform actions based on the match. Refer to and as well as 'case word in' in man bash.

Getting the error code from eslint while running in a pre-commit hook - what's the solution?

Answer №1

Similar questions

I'm having trouble getting my application to output to the console. What could be the issue?

What is the best way to display audio files for clients using a combination of Node.js and AngularJS?

Why is an error being displayed in this location? The argument type is incorrect. Beginning from version 5, only the form of "Object" is permitted when invoking query-related functions

Is there a way to enable toggling of features?

What could be causing the delay in establishing a connection between my Node application and MongoDB?

The npm build command is triggering an error message that reads "Allocation failed due to ineffective mark-compacts near heap limit."

React: Exploring the intricacies of importing components in the component-oriented versus library-oriented approach

Establish req.session within a mongoose schema

Transfer the script from package.json to an npm package

Troubleshooting NPM installation failures with SQLite build

In what way can I incorporate additional functions or multiple functions within an Express route to modify database information?

Issue with form action redirection on Node JS Express server not functioning correctly

"Object.entries seems to be returning only the initial object in the list

Error encountered in lodash.js in Angular 2 framework

When I try to access my parameter in the backend node controller, it returns as undefined

Execute a PHP POST request with dynamic value passing

Bundling with Webpack, utilizing Dev-Middleware, and managing Static Files

MongoDB document queries that do not consider timezones

Creating an HTTP request inside an Export Function in a MEANJS application

Exploring the Dynamic Duo: Node.js and Firebase