Whenever a client connects to my node.js server, it crashes with a 'RangeError: Maximum call stack size exceeded' error. I suspect there's a recursive problem somewhere in my code that I can't seem to find.
This is the code on my server:
require('monitor').start();
var app = require('express')();
var http = require('http').Server(app);
var io = require('socket.io')(http);
app.get('/', function(req, res){
res.sendFile(__dirname + '/index.html');
});
var allClients = [];
io.on('connection', function(socket){
console.log('user joined: ' + socket.request.connection.remoteAddress + ':' + socket.request.connection.remotePort);
socket.address = socket.request.connection.remoteAddress;
socket.port = socket.request.connection.remotePort;
socket.name = '';
socket.xPos = 0;
socket.yPos = 0;
// Send current client list to new connection
socket.emit('client list', allClients);
// Broadcast 'new user' event to existing clients only
var i = 0;
for(i=0;i<allClients.length;i++){
allClients[i].emit('new user', socket.address + '_' + socket.port);
}
// Add new socket to the client array after sending it to other users
allClients.push(socket);
socket.on('chat message', function(msg){
io.emit('chat message', socket.address + ':' + socket.port + ": " + socket.name + ' says: ' + msg);
console.log(socket.address + ":" + socket.port + ": " + socket.name + ' says: ' + msg);
});
socket.on('set_name', function(msg){
socket.name = msg;
console.log(socket.address + ":" + socket.port + ' set name to: ' + msg);
});
socket.on('xPosUpdate', function(msg){
console.log(socket.address + ":" + socket.port + ' set xPos to: ' + msg);
});
socket.on('yPosUpdate', function(msg){
console.log(socket.address + ":" + socket.port + ' set yPos to: ' + msg);
});
socket.on('disconnect', function() {
io.emit('user disconnect', socket.address + '_' + socket.port);
io.emit('chat message', socket.address + ':' + socket.port + ": " + socket.name + ' disconnected.');
console.log('Got disconnect!');
socket = null;
var i = allClients.indexOf(socket);
allClients.splice(i, 1);
});
});
http.listen(3000, function(){
console.log('listening on *:3000');
});
And here's how I'm handling the socket on the client side:
var users = [];
$('#chatInput').submit(function(){
socket.emit('chat message', $('#m').val());
$('#m').val('');
return false;
});
$('#nameInput').submit(function(){
socket.emit('set_name', $('#n').val());
$('#n').val('');
return false;
});
socket.on('client list', function(msg){
$('#messages').append($('<li>').text('Processing client list...'));
var i = 0;
for(i=0;i<msg.length;i++){
$('#messages').append($('<li>').text('Client ' + i + ': ' + msg[i].address + ':' + msg[i].port + ', Name: ' + msg[i].name));
}
});
socket.on('chat message', function(msg){
$('#messages').append($('<li>').text(msg));
});
socket.on('user disconnect', function(msg){
users[msg].unset();
});
socket.on('new user', function(msg){
users[msg] = [];
users[msg].xPos = 0;
users[msg].yPos = 0;
$('#messages').append($('<li>').text(msg));
});